DDS warnings; rs-enum-devs fix; UYVY -> uyvy for ROS2 - #12095
Merged
Conversation
(cherry picked from commit 3ad31095c353c0ed6efd78dd2f516546c15059d7)
(cherry picked from commit 75b7abbd580aa5ddb327661eb84dc037e532dead)
(cherry picked from commit 3e3163efd8bd52831b9258875a31c694e44c7deb)
(cherry picked from commit 2c822708d823ff61efaca218ec030bf635594bc0)
OhadMeir
reviewed
Aug 14, 2023
| set_target_properties (${PROJECT_NAME} PROPERTIES | ||
| FOLDER Tools/dds | ||
| CXX_STANDARD 11 | ||
| CXX_STANDARD 14 |
Contributor
There was a problem hiding this comment.
Can we inherit this from a global setting that applies to SDK and all tools?
Contributor
Author
There was a problem hiding this comment.
There isn't one currently -- the main SDK is 14 but the tools and examples were all left at 11.
OhadMeir
reviewed
Aug 14, 2023
| SwitchArg show_defaults("d", "defaults", "Show the default streams configuration"); | ||
| SwitchArg only_sw_arg( "", "sw-only", "Show only software devices (playback, dds, etc. -- but not USB/HID/etc.)" ); | ||
| SwitchArg only_sw_arg( "", "sw-only", "Show only software devices (playback, DDS, etc. -- but not USB/HID/etc.)" ); | ||
| SwitchArg basic_formats_arg( "", "basic-formats", "Don't show non-raw conversions" ); |
Contributor
There was a problem hiding this comment.
As discussed today, this will evolve into something more than a bool.
Will it be in this PR or a future one?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uyvy(lower-case).