Fix get_intrinsics for unrectified image - #12115
Merged
Merged
Conversation
OhadMeir
force-pushed
the
formats_converter
branch
from
August 21, 2023 06:08
828e5af to
ecabcf1
Compare
OhadMeir
marked this pull request as ready for review
August 21, 2023 08:16
…d_exception but we get stack overflow
…ce there is a call cycle
OhadMeir
force-pushed
the
formats_converter
branch
from
August 22, 2023 11:48
ecabcf1 to
84b1083
Compare
maloel
approved these changes
Aug 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should throw
not_implement_exceptionbut we get stack overflow.Problem was a cycle of calls between cloned profile intrinsics function and raw profile intrinsics function.
We are counting on the device to set the cloned profile function and break the cycle, but the device does not set for unrectified image.
Fixes RealCI issue and also RSDEV-424