Remove recordable<> from many interfaces - #12138
Merged
Merged
Conversation
maloel
force-pushed
the
recordable
branch
3 times, most recently
from
September 4, 2023 14:53
ad18222 to
58c2774
Compare
Contributor
Author
|
Ahem |
Collaborator
|
Did you test record & playback of all streams in the viewer? |
Collaborator
|
Looks fine by me but this needs to be merged after the other PR that exposed new CLI parameters to the |
Nir-Az
self-requested a review
September 10, 2023 18:26
Nir-Az
approved these changes
Sep 10, 2023
Contributor
Author
Yes. And made sure old Viewer could play back new recordings and vice-versa. I'll test some more. |
Contributor
Author
Why, just out of curiosity?
Then remove the change request on the other :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many of the recordable<>-derived snapshots were not actually written to the rosbags, and so were just cluttering code.
Recordable is now only left in option, options, and stream-profile. These may need work too, but this is good for now.
Small refactoring in some spots, but overall removes and simplifies code.
Tracked on [LRS-886]