Refactor device.h - #12200
Merged
Merged
Conversation
SamerKhshiboun
approved these changes
Sep 25, 2023
SamerKhshiboun
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Any reason why libci failed ?
Contributor
Author
Not related. I just reran it: All passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed some unused functions, took stuff out of types.h, etc.
Only last two commits have minor functional changes:
device- moved tods_device(not used in non-uvc devices, like software devices)stream_profileand added commentsSensor.h is next...
Tracked on [LRS-881]