Skip to content

Enable D457 FW update on LibCI - #12209

Merged
Nir-Az merged 2 commits into
realsenseai:developmentfrom
OhadMeir:rs-fw-update
Sep 20, 2023
Merged

Enable D457 FW update on LibCI#12209
Nir-Az merged 2 commits into
realsenseai:developmentfrom
OhadMeir:rs-fw-update

Conversation

@OhadMeir

@OhadMeir OhadMeir commented Sep 19, 2023

Copy link
Copy Markdown
Contributor

The rs-fw-update tool now supports D457, enable the test for it on LibCI

Also, do not run on GHA, there is no need
Tracked on [LRS-738]

@OhadMeir
OhadMeir requested a review from Nir-Az September 19, 2023 07:23
Comment thread unit-tests/test-fw-update.py
devices.acroname = None
import time

# This is the first test running, discover acroname modules.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we care here if it's the first test that runs?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test runs first (priority 0) and is the only that calls devices.acroname.discover().
I am testing based on jetson in context and not camera model, because it cannot be queried before this call.

@Nir-Az Nir-Az left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments

@Nir-Az
Nir-Az merged commit 2a4819e into realsenseai:development Sep 20, 2023
@OhadMeir
OhadMeir deleted the rs-fw-update branch January 13, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants