Y16 calibration format test - #12234
Merged
Nir-Az merged 1 commit intoOct 2, 2023
Merged
Conversation
remibettan
reviewed
Sep 28, 2023
Tamir91
commented
Sep 28, 2023
|
|
||
| profile_y16 = next(p for p in depth_sensor.profiles if p.format() == rs.format.y16) | ||
| test.check(profile_y16) | ||
| log.d(str(profile_y16)) |
remibettan
self-requested a review
September 28, 2023 12:43
Nir-Az
reviewed
Oct 1, 2023
| y16_streamed = True | ||
|
|
||
|
|
||
| timer = Timer(30) |
Collaborator
There was a problem hiding this comment.
Please reduce to 5.
If we don't get a frame in 5 seconds, we have another problem :)
No need to stall the LibCI on that case
Contributor
Author
There was a problem hiding this comment.
You right, we confused with this value too.
Contributor
Author
There was a problem hiding this comment.
Done, a value is 5 now.
Collaborator
|
Let's also delete the old cpp test file, no need anymore right? |
Collaborator
|
Please remove |
Tamir91
force-pushed
the
Y16-calibration-format-test
branch
from
October 2, 2023 08:59
0aa3d80 to
6a90b19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked on [RSDEV-724]
Porting an existing D400 test from Cpp to Python.