hexarray & hexdump - #12241
Merged
Merged
Conversation
(cherry picked from commit 8f01c760d7e9af50b5e1fb8acd54fd197800c9e5)
| namespace string { | ||
|
|
||
|
|
||
| /*static*/ std::string hexarray::to_string( bytes const & bytearray ) |
Contributor
There was a problem hiding this comment.
what about this "static" ? should be commented out or not ?
Contributor
Author
There was a problem hiding this comment.
I put these there on purpose, since it's not always clear that you're looking at a static function member body. I find it helps me understand where I am.
| } | ||
|
|
||
|
|
||
| /*static*/ std::ostream & hexarray::to_stream( std::ostream & os, bytes const & bytearray ) |
SamerKhshiboun
approved these changes
Oct 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON byte-arrays get passed as an array of bytes:
This implements a
hexarrayobject that can be used to communicate byte-arrays in a standard way ("0102abcd"). Compatible with regular JSON array-of-bytes representation ([1,2,3]) (with type/range checks). With unit-tests. Added docs.Tracked on [LRS-899]