remove rs2 structs from context.h - #12289
Merged
Merged
Conversation
maloel
requested review from
OhadMeir and
SamerKhshiboun
and removed request for
SamerKhshiboun
October 12, 2023 07:32
OhadMeir
approved these changes
Oct 16, 2023
OhadMeir
left a comment
Contributor
There was a problem hiding this comment.
Good job simplifying the code and cleaning unneeded includes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
rs2_device_liststruct, outside oflibrealsensenamespace, was used all the way in the device factories.std::vector< std::shared_ptr< device_info > >insteadcontext::on_device_changes()to accept a callback, rather than rs2 conceptsrs2_device_infoand changedrs2_device_listto also usestd::vector< std::shared_ptr< device_info > >rs2_device_listinto rs.cpprs2_stream_profileintostream.huntil the latter is refactored, toocontext.hincludes where not neededTracked on [LRS-921]