USB missing icon bug fix - #12322
Merged
Merged
Conversation
Collaborator
|
All tests were failed, |
Nir-Az
reviewed
Nov 2, 2023
| # Copyright(c) 2021 Intel Corporation. All Rights Reserved. | ||
|
|
||
| import pyrealsense2 as rs | ||
| from rspy import test |
Collaborator
There was a problem hiding this comment.
no #test:device ... no test running..
Nir-Az
reviewed
Nov 2, 2023
|
|
||
| dev = test.find_first_device_or_exit() | ||
|
|
||
| test.check(dev.supports(rs.camera_info.usb_type_descriptor)) |
Collaborator
There was a problem hiding this comment.
Please add querying and making sure not Undefined
Contributor
Author
There was a problem hiding this comment.
With the bug present this check was enough to fail it, but I'll add a check making sure the type is not Undefined
Collaborator
|
Please rebase your branch, LibCI fails |
Collaborator
|
Need to exclude D457 as it is not USB based.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked on [LRS-932]