Skip to content

move all ExternalProjectTargets into '3rd Party' - #12331

Merged
maloel merged 1 commit into
realsenseai:developmentfrom
maloel:3rd-party
Oct 29, 2023
Merged

move all ExternalProjectTargets into '3rd Party'#12331
maloel merged 1 commit into
realsenseai:developmentfrom
maloel:3rd-party

Conversation

@maloel

@maloel maloel commented Oct 29, 2023

Copy link
Copy Markdown
Contributor

Today we have some projects, like GLFW3, outside any hierarchy in Visual Studio.
Others are in "ExternalProjectTargets", which isn't nice-looking.

This moves everything into 3rd Party

Tracked on [LRS-939]

@maloel
maloel requested a review from Nir-Az October 29, 2023 08:13
@Nir-Az

Nir-Az commented Oct 29, 2023

Copy link
Copy Markdown
Collaborator

Please make sure release flow work before we merge this

@maloel

maloel commented Oct 29, 2023

Copy link
Copy Markdown
Contributor Author

Please make sure release flow work before we merge this

This is just the Visual Studio organization... no effect on the build...
But OK, I'll run the release flow.

@maloel

maloel commented Oct 29, 2023

Copy link
Copy Markdown
Contributor Author

@Nir-Az Nir-Az left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maloel
maloel merged commit 851aed5 into realsenseai:development Oct 29, 2023
@maloel
maloel deleted the 3rd-party branch October 29, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants