Fps permutations test - #12335
Merged
Merged
Conversation
Collaborator
|
@AviaAv always check if your test indeed run in all required OS. |
Nir-Az
reviewed
Oct 29, 2023
Nir-Az
reviewed
Oct 29, 2023
Nir-Az
reviewed
Oct 29, 2023
Nir-Az
reviewed
Oct 29, 2023
Nir-Az
reviewed
Oct 29, 2023
Nir-Az
reviewed
Oct 29, 2023
Nir-Az
reviewed
Oct 29, 2023
Nir-Az
reviewed
Oct 29, 2023
Nir-Az
reviewed
Oct 29, 2023
Nir-Az
reviewed
Oct 29, 2023
Nir-Az
reviewed
Oct 29, 2023
OhadMeir
reviewed
Oct 30, 2023
OhadMeir
reviewed
Oct 30, 2023
OhadMeir
reviewed
Oct 31, 2023
OhadMeir
reviewed
Oct 31, 2023
Collaborator
|
Please rebase development and run CI manually with nightly context and verify the test run and pass on all supported OS's |
OhadMeir
reviewed
Nov 5, 2023
| f"{sensor_profile_dict[sensor_key][0].stream_name()} is {expected_fps_dict[sensor_key]}" | ||
| f" on {get_resolution(sensor_profile_dict[sensor_key][0])}\n") | ||
| s = s.replace("on (0, 0)", "") # remove no resolution for Motion Module profiles | ||
| s += "***************" |
Contributor
There was a problem hiding this comment.
Remove. Might be helpful for debug but we don't want this in the final logs
OhadMeir
reviewed
Nov 5, 2023
| funcs_dict = generate_functions(sensor_fps_dict) | ||
|
|
||
| for key in sensor_profiles_dict: | ||
| sensor = key |
Contributor
There was a problem hiding this comment.
Just use for sensor in ...
OhadMeir
reviewed
Nov 5, 2023
| sensor_fps_dict[key] /= TIME_TO_COUNT_FRAMES | ||
| # now for each sensor we have the average fps received | ||
|
|
||
| sensor = key |
OhadMeir
reviewed
Nov 5, 2023
| ############################################# | ||
| # ---------- Core Test Functions ---------- # | ||
| ############################################# | ||
| def check_fps(expected_fps, fps_measured): |
Contributor
There was a problem hiding this comment.
Rename check_fps_dict. Also it is better to have measured fps as the first argument for consistency with our other check functions use (and also your own check_fps_pair).
OhadMeir
reviewed
Nov 13, 2023
| # to avoid having a long run time, we don't choose the same stream more than once | ||
| if p.stream_type() not in stream_types_added: | ||
| if p.stream_type() == rs.stream.infrared: | ||
| if p.stream_index() != 1: |
Contributor
There was a problem hiding this comment.
Style comment (decide if you want to change) - this is very indented you can use and instead of the last if, or better yet, move the last 3 ifs to a function should_add_profile
OhadMeir
reviewed
Nov 13, 2023
| if p.stream_type() not in stream_types_added: | ||
| if p.stream_type() == rs.stream.infrared: | ||
| if p.stream_index() != 1: | ||
| continue # on some devices, using Infrared 1 seems to have better fps than IR/IR2 |
Contributor
There was a problem hiding this comment.
The comment is not clear - which models and why...
According to our talk with Idan you can use validation KPIs are for depth+IR1 not IR2
AviaAv
force-pushed
the
fps-perm-test
branch
from
December 25, 2023 14:50
ca25baf to
721218f
Compare
AviaAv
force-pushed
the
fps-perm-test
branch
2 times, most recently
from
March 12, 2024 07:15
e159742 to
e35a008
Compare
Nir-Az
approved these changes
Jul 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked on [LRS-909]