Syncer debug - #12342
Merged
Merged
Conversation
Nir-Az
reviewed
Oct 31, 2023
| bool try_parse( const std::string & option_name, rs2_option & result ); | ||
|
|
||
| RS2_ENUM_HELPERS( rs2_stream, STREAM ) | ||
| LRS_EXTENSION_API char const * get_abbr_string( rs2_stream ); |
Collaborator
There was a problem hiding this comment.
Can you give it a meaningfull name?
abbr is not understood
Contributor
Author
There was a problem hiding this comment.
It's the standard shorthand for abbreviated.
Collaborator
There was a problem hiding this comment.
I had to open google translate to even understand what abbreviated means.
I would normally use more common words, but it's your call here
Nir-Az
reviewed
Oct 31, 2023
| s << "[" << f.get_stream()->get_stream_type(); | ||
| s << "/" << f.get_stream()->get_unique_id(); | ||
| s << "[" << get_abbr_string( f.get_stream()->get_stream_type() ); | ||
| s /*<< "."*/ << f.get_stream()->get_unique_id(); |
Nir-Az
reviewed
Nov 1, 2023
| { | ||
| switch( value ) | ||
| { | ||
| case RS2_STREAM_ANY: return "any"; |
Collaborator
There was a problem hiding this comment.
Why use only lower case here and all other start with uppercase?
Conf for exanple?
Consider aligning it
Contributor
Author
There was a problem hiding this comment.
I wanted it to stand out, but OK: changed.
Nir-Az
reviewed
Nov 1, 2023
| # know what to match to in the beginning) | ||
|
|
||
| # (sync.cpp:396) ... missing Color/66, next expected 63231.348758 | ||
| sw.generate_color_frame( frame_number=1730, timestamp=63198.01542, next_expected=63231.348758 ) |
Collaborator
There was a problem hiding this comment.
This is some kind of regression no?
Before the changes the syncer could output this first set?
Nir-Az
reviewed
Nov 1, 2023
| sw.expect( depth_frame=1749, nothing_else=True ) | ||
|
|
||
|
|
||
| #ing-block.cpp:55) --> syncing [Depth/63 #1750 @63481.48] |
Nir-Az
approved these changes
Nov 1, 2023
# Conflicts: # src/sync.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are additional debug changes I made for the syncer with the AH investigation.
Added the use-case unit-test that we saw, though I'm not sure if it adds value. Comments welcome.
No functional changes to librealsense.
Related to [RSDSO-19336]