Updating minimal_cmake_version test - #12360
Merged
maloel merged 7 commits intoNov 19, 2023
Merged
Conversation
Tamir91
force-pushed
the
cmake_minimal_version_test_upgrading
branch
from
November 5, 2023 18:13
b8cbe3e to
243fe48
Compare
Collaborator
|
@maloel please help reviewing this change raised by you :) |
maloel
reviewed
Nov 6, 2023
Tamir91
force-pushed
the
cmake_minimal_version_test_upgrading
branch
2 times, most recently
from
November 8, 2023 09:17
d19d386 to
111fa27
Compare
Tamir91
force-pushed
the
cmake_minimal_version_test_upgrading
branch
from
November 13, 2023 08:05
fbebf17 to
b420f51
Compare
maloel
reviewed
Nov 15, 2023
maloel
reviewed
Nov 15, 2023
maloel
reviewed
Nov 15, 2023
Tamir91
commented
Nov 15, 2023
maloel
reviewed
Nov 16, 2023
maloel
reviewed
Nov 16, 2023
maloel
approved these changes
Nov 16, 2023
Tamir91
force-pushed
the
cmake_minimal_version_test_upgrading
branch
from
November 16, 2023 10:39
60eb99d to
8b5ab50
Compare
This test comparing number by number numbers in CMake version unnessary print removed duplicate line removed pattern version changed small fixes code refactored code cleaned attempt cast float to string
I want to see grep failed and GHA failed test.
grep has been improved to produce meaningful error output in case CMake version not found.
Tamir91
force-pushed
the
cmake_minimal_version_test_upgrading
branch
from
November 16, 2023 14:56
3507a23 to
3ac15a0
Compare
maloel
approved these changes
Nov 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked on [LRS-952]