Skip to content

remove platform dependency in stream.h - #12368

Merged
maloel merged 1 commit into
realsenseai:developmentfrom
maloel:stream-profile
Nov 9, 2023
Merged

remove platform dependency in stream.h#12368
maloel merged 1 commit into
realsenseai:developmentfrom
maloel:stream-profile

Conversation

@maloel

@maloel maloel commented Nov 6, 2023

Copy link
Copy Markdown
Contributor

Derivations of stream_profile_base incorporate platform::stream-profile needlessly. Only backend-derived profiles need this.

  • Remove platform dependence; only backend implementations now contain the platform data
  • This simplifies and enables default construction of profiles without arguments

Tracked on [LRS-950]

@maloel
maloel requested a review from OhadMeir November 6, 2023 14:17
Comment thread src/stream.h

@OhadMeir OhadMeir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maloel
maloel merged commit ce2d6a0 into realsenseai:development Nov 9, 2023
@maloel
maloel deleted the stream-profile branch November 9, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants