Skip to content

add run-unit-tests --device <> - #12471

Merged
maloel merged 4 commits into
realsenseai:developmentfrom
maloel:run-by-dev
Dec 4, 2023
Merged

add run-unit-tests --device <>#12471
maloel merged 4 commits into
realsenseai:developmentfrom
maloel:run-by-dev

Conversation

@maloel

@maloel maloel commented Dec 4, 2023

Copy link
Copy Markdown
Contributor

E.g., with two devices:

-D- discovering Acroname modules ...
-D-     ... Model: 19 LinkType: USB(serial: F112637D)
-D-     ... port 6: 009423050073 <pyrealsense2.device: D435I (S/N: 036522070660  FW: 5.15.0.2  UNLOCKED  on USB3.2)>
-D-     ... port 0: 151223063973 <pyrealsense2.device: D455 (S/N: 213522254158  FW: 5.15.1  UNLOCKED  on USB3.2)>

Running run-unit-tests ... --device 151223063973 will run only on the D455.
Likewise, run-unit-tests ... --device D435 will run only on the D435I.
Can use product line, too: --device 'D400*'

Any tests that need devices other than the specified --device will not fail the run like they do if those devices do not exist.

Tracked on [LRS-974]

@maloel maloel added the ci CI-related: does not change library behavior label Dec 4, 2023
@maloel
maloel requested a review from Nir-Az December 4, 2023 06:16
@Nir-Az

Nir-Az commented Dec 4, 2023

Copy link
Copy Markdown
Collaborator

We need all cameras connected?
Our main issue is that we want it to run even if we don't have cameras that we don't want to run on.
i.e.
Acroname with only D455, and I wish to run only D455 / D400* tests
Is that possible?

@maloel

maloel commented Dec 4, 2023

Copy link
Copy Markdown
Contributor Author

We need all cameras connected? Our main issue is that we want it to run even if we don't have cameras that we don't want to run on. i.e. Acroname with only D455, and I wish to run only D455 / D400* tests Is that possible?

Don't understand.
It'll run same as before, but ignore any cameras you don't specify. I think it's what you mean?
Call me.

@maloel

maloel commented Dec 4, 2023

Copy link
Copy Markdown
Contributor Author

There's a problem with the scenario I described, where D400* returns only a single device. Fixing it now...

@Nir-Az

Nir-Az commented Dec 4, 2023

Copy link
Copy Markdown
Collaborator

Not sure I understand all but if it works.. I approve :)

@maloel

maloel commented Dec 4, 2023

Copy link
Copy Markdown
Contributor Author

Not sure I understand all but if it works.. I approve :)

I guess you'll just have to try and tell me!

@maloel
maloel merged commit 5858a93 into realsenseai:development Dec 4, 2023
@maloel
maloel deleted the run-by-dev branch December 4, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI-related: does not change library behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants