Can update options automatically, get notification of value change - #12483
Merged
Conversation
maloel
reviewed
Dec 6, 2023
maloel
reviewed
Dec 6, 2023
maloel
reviewed
Dec 6, 2023
maloel
reviewed
Dec 6, 2023
maloel
reviewed
Dec 6, 2023
Nir-Az
reviewed
Dec 6, 2023
Nir-Az
reviewed
Dec 6, 2023
Nir-Az
reviewed
Dec 6, 2023
maloel
reviewed
Dec 6, 2023
maloel
reviewed
Dec 6, 2023
maloel
reviewed
Dec 6, 2023
maloel
reviewed
Dec 6, 2023
OhadMeir
force-pushed
the
development
branch
from
December 11, 2023 07:25
52396d1 to
2d10190
Compare
maloel
reviewed
Dec 11, 2023
maloel
reviewed
Dec 11, 2023
maloel
reviewed
Dec 11, 2023
maloel
reviewed
Dec 11, 2023
maloel
reviewed
Dec 11, 2023
maloel
reviewed
Dec 11, 2023
maloel
reviewed
Dec 11, 2023
maloel
reviewed
Dec 11, 2023
maloel
reviewed
Dec 11, 2023
maloel
reviewed
Dec 11, 2023
maloel
reviewed
Dec 11, 2023
maloel
reviewed
Dec 11, 2023
maloel
reviewed
Dec 11, 2023
maloel
reviewed
Dec 11, 2023
maloel
reviewed
Dec 11, 2023
OhadMeir
force-pushed
the
development
branch
from
December 24, 2023 14:00
954d423 to
6730ac6
Compare
maloel
reviewed
Dec 25, 2023
maloel
reviewed
Dec 25, 2023
maloel
reviewed
Dec 25, 2023
…wake from sleep when stopping
maloel
reviewed
Dec 26, 2023
maloel
reviewed
Dec 26, 2023
maloel
reviewed
Dec 26, 2023
maloel
reviewed
Dec 26, 2023
maloel
reviewed
Dec 26, 2023
maloel
reviewed
Dec 26, 2023
|
|
||
| options_watcher::~options_watcher() | ||
| { | ||
| _alive = false; |
Contributor
There was a problem hiding this comment.
Don't need to clear _options inside a mutex any more; don't need the try-catch, either.
Contributor
Author
There was a problem hiding this comment.
Not locking before clear. try-catch needed because clear and join might throw.
Contributor
There was a problem hiding this comment.
But you don't need the clear()...
Contributor
There was a problem hiding this comment.
And if join() might throw, please catch it inside stop()...
Contributor
Author
There was a problem hiding this comment.
I prefer to clear explicitly, but locking is not needed.
Also found out clear has a noexcept overload. Catching join errors in stop.
Contributor
There was a problem hiding this comment.
I'm sorry, I don't agree - if you clear, then a lock is necessary.
You don't need to clear.
OhadMeir
force-pushed
the
development
branch
from
December 26, 2023 11:41
f499e19 to
cd0b14e
Compare
maloel
reviewed
Dec 27, 2023
| rsutils::subscription register_options_changed_callback( options_watcher::callback && cb ) override | ||
| { | ||
| throw not_implemented_exception( "Registering options value changed callback is not implemented for this sensor" ); | ||
| LOG_ERROR( "Registering options value changed callback is not implemented for this sensor" ); |
Contributor
There was a problem hiding this comment.
Why? I don't think this is good...?
Contributor
Author
There was a problem hiding this comment.
If we throw then the viewer cannot play recorded files
Contributor
Author
There was a problem hiding this comment.
Reverted change. Viewer handling the exception
OhadMeir
force-pushed
the
development
branch
from
December 27, 2023 08:31
de5c1c8 to
45df20e
Compare
…tions setting callback.
OhadMeir
force-pushed
the
development
branch
from
December 28, 2023 08:07
45df20e to
08f25fb
Compare
OhadMeir
force-pushed
the
development
branch
from
December 28, 2023 12:16
8a431c8 to
9bbe102
Compare
maloel
reviewed
Jan 1, 2024
maloel
reviewed
Jan 1, 2024
maloel
reviewed
Jan 1, 2024
maloel
reviewed
Jan 1, 2024
maloel
approved these changes
Jan 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added option_updater class that handles auto query of registered options.
Added C and CPP API to register a value change notification callback .
Added Python API and unit test
Also fixed bug in cpp unit tests - on
restart_first_device_and_return_depth_sensorold device was used after HW reset instead of new device.