Skip to content

helper functions for formatted values on metadata - #12550

Merged
Nir-Az merged 2 commits into
realsenseai:developmentfrom
AviaAv:verdict-text
Jan 2, 2024
Merged

helper functions for formatted values on metadata#12550
Nir-Az merged 2 commits into
realsenseai:developmentfrom
AviaAv:verdict-text

Conversation

@AviaAv

@AviaAv AviaAv commented Jan 1, 2024

Copy link
Copy Markdown
Contributor

Tracked on: [RSDEV-1306]

@AviaAv
AviaAv requested a review from Nir-Az January 1, 2024 13:43
Comment thread common/stream-model.cpp Outdated

bool stream_model::should_show_in_hex(rs2_frame_metadata_value& md_val) const
{
static std::unordered_set< rs2_frame_metadata_value > show_in_hex = {};

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment
place in the SET metadata type you wish to display in HEX format

Comment thread common/stream-model.h Outdated
rsutils::number::stabilized_value<float> _stabilized_reflectivity;

std::string format_value(rs2_frame_metadata_value& md_val, rs2_metadata_type& attribute_val) const;
bool stream_model::should_show_in_hex(rs2_frame_metadata_value& md_val) const;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove stream_model:: in header

@AviaAv
AviaAv requested a review from Nir-Az January 2, 2024 08:46
@Nir-Az
Nir-Az merged commit 8af2a77 into realsenseai:development Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants