Fixing Depth Alignment in Align-GL processing block - #12556
Merged
Conversation
Arun-Prasad-V
force-pushed
the
align-gl-example
branch
from
January 12, 2024 10:45
87e2905 to
33c359b
Compare
Contributor
Author
|
Results from the rs-align-gl example:
|
Arun-Prasad-V
commented
Jan 12, 2024
maloel
approved these changes
Jan 14, 2024
maloel
left a comment
Contributor
There was a problem hiding this comment.
@Arun-Prasad-V Is this ready for merge, if there's still a known issue?
Nir-Az
reviewed
Jan 14, 2024
Nir-Az
reviewed
Jan 14, 2024
| project(RealsenseExamplesAlignGl ) | ||
|
|
||
| if(BUILD_GRAPHICAL_EXAMPLES) | ||
| add_executable(rs-align-gl rs-align-gl.cpp ../../third-party/imgui/imgui.cpp ../../third-party/imgui/imgui_draw.cpp ../../third-party/imgui/imgui_impl_glfw.cpp) |
Nir-Az
reviewed
Jan 14, 2024
Collaborator
|
The example looks great!
|
Arun-Prasad-V
force-pushed
the
align-gl-example
branch
2 times, most recently
from
January 15, 2024 07:56
4673a37 to
33c359b
Compare
Arun-Prasad-V
marked this pull request as ready for review
January 16, 2024 07:26
Nir-Az
reviewed
Jan 18, 2024
| project(RealsenseExamplesAlignGl ) | ||
|
|
||
| # Save the command line compile commands in the build output | ||
| set(CMAKE_EXPORT_COMPILE_COMMANDS 1) |
Collaborator
There was a problem hiding this comment.
What do you mean by save ?
Collaborator
There was a problem hiding this comment.
I don't remember we use this line in other examples
Contributor
Author
There was a problem hiding this comment.
I didn't realize this. It got included when I took reference CMakelists.txt from rs-gl example
Collaborator
There was a problem hiding this comment.
OK, not a big deal but looks redundent
If enabled, generates a compile_commands.json file...
Nir-Az
approved these changes
Jan 18, 2024
This was referenced Jan 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked on LRS-514.
Related GH issues: #11827, #7611
Added an example as well.