Improve test.remote reliability - #12573
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During development I noticed many cases, even locally, of tests failing with output like this:
test.remoteuses a specific string___ready\nto signify to the client that it's in a ready state.Notice how, in the above, this string is split by a line that's output from another thread! This breaks it up, the client doesn't realize it's ready, and times out - failing the test.
This attempts to identify such cases and deal with them. So far it's worked in my testing. Hopefully it will help in GHA, too.
Likewise:
Googling this shows this is the result of "when a thread tries to join itself." Try to avoid this, too...
Added some minor DDS stuff, in own commits that should be self-contained. No new functionality (sample-lost callbacks don't work yet because of an eProsima bug -- I reported it and they fixed it).