Frame queue per stream, not per extension - #12575
Merged
Merged
Conversation
OhadMeir
force-pushed
the
development
branch
2 times, most recently
from
January 17, 2024 07:50
f49d17f to
9bc101c
Compare
Nir-Az
reviewed
Jan 17, 2024
| { | ||
| public: | ||
| frame_source(uint32_t max_publish_list_size = 16); | ||
| //using stream_uid = std::pair< rs2_stream, int >; // Stream type and index |
Nir-Az
reviewed
Jan 17, 2024
Nir-Az
reviewed
Jan 17, 2024
| return _archive[RS2_EXTENSION_VIDEO_FRAME]->begin_callback(); | ||
| // return _archive[RS2_EXTENSION_DEPTH_FRAME]->begin_callback(); | ||
| if( id.second >= RS2_EXTENSION_COUNT ) | ||
| id.first = RS2_STREAM_COUNT; // For added extensions like GPU accelerated frames |
Contributor
Author
There was a problem hiding this comment.
Yes needed.
When adding an extension we need to create the archive because add_extension is templated with the archive type. At that stage we don't know the stream type that will be used, but cannot keep the type for later allocation.
When using the allocated archive we need to find it with the same key.
Nir-Az
reviewed
Jan 17, 2024
| if( it == _archive.end() ) | ||
| { | ||
| create_archive( id ); | ||
| it = _archive.find( id ); // Now will successfully find |
Contributor
Author
There was a problem hiding this comment.
Optimized. create_archive now returns iterator to new archive.
Nir-Az
reviewed
Jan 17, 2024
Nir-Az
reviewed
Jan 17, 2024
| throw wrong_api_call_sequence_exception( "Requested frame type is not supported!" ); | ||
| { | ||
| create_archive( id ); | ||
| it = _archive.find( id ); // Now will successfully find |
Nir-Az
self-requested a review
January 17, 2024 10:35
…terator from create_archive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently frame archives are created per extension type. There are several streams that use
RS2_EXTENSION_VIDEO_FRAMEand the queue might get full, especially if a syncher is involved.This PR creates archives also based on the stream type, so IR1+2 still share a queue but they come together and don't have to wait in the syncher.
Tracked on [RSDEV-599]