fix json = json_ref - #12615
Merged
Merged
Conversation
OhadMeir
reviewed
Jan 28, 2024
| // operator=() get called. But the implementation is a copy-and-swap one, meaning it attempts to construct a json value | ||
| // from the argument. Since the argument isn't a json object (doesn't matter that it has a conversion operator), it does | ||
| // this by attempting to deserialize it with to_json()! We need to avoid this, for this usage and others... | ||
| inline void to_json( rsutils::json & j, json_ref const & jr ) |
Contributor
There was a problem hiding this comment.
This gets called automatically by the json constructor?
Contributor
Author
There was a problem hiding this comment.
Yes, they have a constructor to take any unknown type and convert it to json. It does this via to_json.
OhadMeir
approved these changes
Jan 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This didn't work... :(
The nesting returns a json_ref, correctly.
operator=()gets called. But the implementation is a copy-and-swap one, meaning it attempts to construct a json value from the argument. Since the argument isn't a json object (doesn't matter that it has a conversion operator), it does this by attempting to deserialize it with to_json()!Can also be fixed by:
But this requires handling at every usage.
So we provide a simple to_json() implementation...
Related to #12555.