Skip to content

[LRS-GL] Support for Align-SSE - #12637

Merged
Nir-Az merged 2 commits into
realsenseai:developmentfrom
Arun-Prasad-V:lrs_gl_align_sse
Feb 14, 2024
Merged

[LRS-GL] Support for Align-SSE#12637
Nir-Az merged 2 commits into
realsenseai:developmentfrom
Arun-Prasad-V:lrs_gl_align_sse

Conversation

@Arun-Prasad-V

Copy link
Copy Markdown
Contributor

Tracked on LRS-1007

With LRS-GL library, in case if user chooses CPU acceleration ('SSE3' is enabled during build), create librealsense::align_sse class object instead of librealsense::align.

@Arun-Prasad-V
Arun-Prasad-V requested a review from Nir-Az February 6, 2024 09:03

@Nir-Az Nir-Az left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix CI issues

Comment thread src/proc/align.cpp Outdated
#include "align.h"
#include "stream.h"

#ifdef RS2_USE_CUDA

@Nir-Az Nir-Az Feb 8, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible a platform will have both CUDA & SSE3 enabled?
Please check because if yes, we will have to choose as this may not compile

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nir-Az, the user cannot choose to run with or without "SSE3". If CPU processing is preferred, LRS should automatically detect and use "SSE3" wherever possible.

If "BUILD_WITH_CUDA" flag is enabled, CUDA implementations will be preferred. User cannot dynamically choose between CUDA or SSE3.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I know, just wanted to make sure that if the user build with Cuda, and gis CPU support SSSE,
He will include both headers.
We need to make sure the headers does not conflict.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Headers are not conflicting. Anyway, updated them to avoid such confusions.

Comment thread src/proc/align.cpp Outdated
@Arun-Prasad-V
Arun-Prasad-V requested a review from Nir-Az February 14, 2024 05:23
@Nir-Az
Nir-Az merged commit b6f4aed into realsenseai:development Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants