Skip to content

Non-float option fixes - #12791

Merged
maloel merged 2 commits into
realsenseai:developmentfrom
maloel:option-fixes
Mar 31, 2024
Merged

Non-float option fixes#12791
maloel merged 2 commits into
realsenseai:developmentfrom
maloel:option-fixes

Conversation

@maloel

@maloel maloel commented Mar 25, 2024

Copy link
Copy Markdown
Contributor
  • options_watcher was using the old query() to update values but this turned all the options into floats; instead, it now uses get_value()
  • non-float options were displaying as zeroes; fixed
  • integer sliders were showing decimal points; fixed

@maloel
maloel requested a review from OhadMeir March 25, 2024 07:43
@Nir-Az

Nir-Az commented Mar 25, 2024

Copy link
Copy Markdown
Collaborator

non-float options were displaying as zeroes , is this issue affect 5.16?

@maloel

maloel commented Mar 25, 2024

Copy link
Copy Markdown
Contributor Author

non-float options were displaying as zeroes , is this issue affect 5.16?

No, only dds has non-float options.

@OhadMeir OhadMeir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@maloel
maloel merged commit 58c8961 into realsenseai:development Mar 31, 2024
@maloel
maloel deleted the option-fixes branch March 31, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants