Skip to content

C++ 17 fixes - #12862

Merged
Nir-Az merged 1 commit into
realsenseai:developmentfrom
SpexAI:c++-17
May 20, 2024
Merged

C++ 17 fixes#12862
Nir-Az merged 1 commit into
realsenseai:developmentfrom
SpexAI:c++-17

Conversation

@rurban

@rurban rurban commented Apr 18, 2024

Copy link
Copy Markdown

Fix missing C++17 headers in fw-logs-formatting-options

gcc-14

[ 60%] Building CXX object CMakeFiles/realsense2.dir/src/firmware_logger_device.cpp.o
In file included from /home/rurban/librealsense/src/fw-logs/fw-logs-formatting-options.cpp:4:
/home/rurban/librealsense/src/fw-logs/fw-logs-formatting-options.h:31:42: error: ‘uint32_t’ has not been declared
   31 |             std::string get_thread_name( uint32_t thread_id ) const;
      |                                          ^~~~~~~~
/home/rurban/librealsense/src/fw-logs/fw-logs-formatting-options.h:32:42: error: ‘uint32_t’ has not been declared
   32 |             std::string get_module_name( uint32_t module_id ) const;
      |                                          ^~~~~~~~
/home/rurban/librealsense/src/fw-logs/fw-logs-formatting-options.cpp:42:21: error: no declaration matches ‘std::string librealsense::fw_logs::fw_logs_formatting_options::get_thread_name(uint32_t) const’
   42 |         std::string fw_logs_formatting_options::get_thread_name( uint32_t thread_id ) const
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~
/home/rurban/librealsense/src/fw-logs/fw-logs-formatting-options.h:31:25: note: candidate is: ‘std::string librealsense::fw_logs::fw_logs_formatting_options::get_thread_name(int) const’
   31 |             std::string get_thread_name( uint32_t thread_id ) const;
      |                         ^~~~~~~~~~~~~~~
/home/rurban/librealsense/src/fw-logs/fw-logs-formatting-options.h:23:15: note: ‘class librealsense::fw_logs::fw_logs_formatting_options’ defined here
   23 |         class fw_logs_formatting_options
      |               ^~~~~~~~~~~~~~~~~~~~~~~~~~
/home/rurban/librealsense/src/fw-logs/fw-logs-formatting-options.cpp:51:21: error: no declaration matches ‘std::string librealsense::fw_logs::fw_logs_formatting_options::get_module_name(uint32_t) const’
   51 |         std::string fw_logs_formatting_options::get_module_name( uint32_t module_id ) const
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~
/home/rurban/librealsense/src/fw-logs/fw-logs-formatting-options.h:32:25: note: candidate is: ‘std::string librealsense::fw_logs::fw_logs_formatting_options::get_module_name(int) const’
   32 |             std::string get_module_name( uint32_t module_id ) const;
      |                         ^~~~~~~~~~~~~~~
/home/rurban/librealsense/src/fw-logs/fw-logs-formatting-options.h:23:15: note: ‘class librealsense::fw_logs::fw_logs_formatting_options’ defined here
   23 |         class fw_logs_formatting_options
      |               ^~~~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [CMakeFiles/realsense2.dir/build.make:1266: CMakeFiles/realsense2.dir/src/fw-logs/fw-logs-formatting-options.cpp.o] Error 1

@sysrsbuild

Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

@Nir-Az

Nir-Az commented May 12, 2024

Copy link
Copy Markdown
Collaborator

Thanks for the PR,
Closed and re-opened to trigger CI.
Can you add the compiler you use and error you get?

@Nir-Az
Nir-Az requested a review from OhadMeir May 12, 2024 05:38
Comment thread src/fw-logs/fw-logs-formatting-options.cpp
@Nir-Az
Nir-Az merged commit 7d70431 into realsenseai:development May 20, 2024
@rurban
rurban deleted the c++-17 branch May 23, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants