LibCI - Recycle device on retry - #12911
Merged
Merged
Conversation
Nir-Az
marked this pull request as ready for review
May 9, 2024 06:05
Nir-Az
marked this pull request as draft
May 9, 2024 06:05
Nir-Az
marked this pull request as ready for review
May 9, 2024 06:24
maloel
reviewed
May 10, 2024
maloel
reviewed
May 13, 2024
| log._n_errors -= 1 | ||
| time.sleep( 1 ) # small pause between tries | ||
| if no_reset: | ||
| time.sleep(1) # small pause between tries |
Contributor
There was a problem hiding this comment.
This should happen only if retry < test.config.retries.
Anyway, same comment as before: move to before line 446 and check if retry > 0. And the log (line 452) should now be taken care of by test_wrapper_(), right?
Collaborator
Author
There was a problem hiding this comment.
There is a difference between retry and repeat, repeat is currently handles inside, retry outside.
I will think about it.
maloel
reviewed
May 13, 2024
| opts.add( '--rslog' ) | ||
| try: | ||
| if repetition > 0: | ||
| log.d("repeat #", repetition + 1) |
Contributor
There was a problem hiding this comment.
I think this is a retry, not a repetition? Oh wait... I think you want to check both retry and repetition here... but I think configuration_str() already does all this for you, why not use it?
Replace line 414 with:
if not log.is_debug_on() or repetition or retry:
maloel
approved these changes
May 13, 2024
maloel
added a commit
to maloel/librealsense
that referenced
this pull request
May 15, 2024
maloel
added a commit
that referenced
this pull request
May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a test fails and retry it doesn't reset the device so normally it fails again.
This PR make sure the device is resetting before each try