Flow controller & misc - #12924
Merged
Merged
Conversation
OhadMeir
reviewed
May 12, 2024
|
|
||
| class dds_topic; | ||
| class dds_publisher; | ||
| class dds_participant; |
OhadMeir
reviewed
May 15, 2024
| // Separate one field from the previous: | ||
| // os << field::separator << "whatever"; | ||
| // If any indent is set, this will be on a separate line! | ||
| static std::ostream & separator( std::ostream & ); |
Contributor
There was a problem hiding this comment.
The separator/value notation is not that clear. Maybe use key/value or name/value notation
OhadMeir
approved these changes
May 15, 2024
This was referenced May 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need ability to use flow-controllers in DDS, to limit data rates. This is the prep work, including everything but the actual creation and usage of the flow-controllers (pending changes from eProsima):
dds_topic_writer,dds_topic_reader, anddds_participantqos overridestopic-sendand addtopic-sinkutilitiesPlus some misc stuff:
make_less_screamyuse a more generic algorithmword_formatthat can do genericdash_caseconversionsrsutils::iosnamespace for ios manipulationsios::fieldandios::indent, to make structure output to stream more standardizedformat_conversion, per Nir's requestrecommended-filtersinstream-optionsSerialization looks like this: