Skip to content

LRS_LOG_LEVEL fix; enable log optimizations - #12978

Merged
maloel merged 3 commits into
realsenseai:developmentfrom
maloel:logging-fixes
May 29, 2024
Merged

LRS_LOG_LEVEL fix; enable log optimizations#12978
maloel merged 3 commits into
realsenseai:developmentfrom
maloel:logging-fixes

Conversation

@maloel

@maloel maloel commented May 29, 2024

Copy link
Copy Markdown
Contributor

LRS_LOG_LEVEL wasn't creating log files because of a bug (since #11186, 8-Dec'22) leaving the log filename empty. Tracked on [LRS-1125].

Also, PR #12959 optimizations were actually not working: all the levels were still enabled even if to-console and to-file were off! This disables unused log levels and the optimization actually works.

@maloel

maloel commented May 29, 2024

Copy link
Copy Markdown
Contributor Author

@realsenseai realsenseai deleted a comment from sysrsbuild May 29, 2024
@Nir-Az

Nir-Az commented May 29, 2024

Copy link
Copy Markdown
Collaborator

Will a file be generated now if the user set the env var?
Can you change the GHA log path to see if now we detect a file?
https://github.com/IntelRealSense/librealsense/blob/ff8a9fb213ec1227394de4060743b0ed61171985/.github/workflows/buildsCI.yaml#L303
should be probably:
path: build/${{env.LRS_RUN_CONFIG}}/*.log

and
https://github.com/IntelRealSense/librealsense/blob/ff8a9fb213ec1227394de4060743b0ed61171985/.github/workflows/buildsCI.yaml#L465

Should be
path: build/${{env.LRS_BUILD_CONFIG}}/*.log

@maloel

maloel commented May 29, 2024

Copy link
Copy Markdown
Contributor Author

Will a file be generated now if the user set the env var?

Yes, I tested this.

@maloel

maloel commented May 29, 2024

Copy link
Copy Markdown
Contributor Author

Log files are there now

@maloel
maloel merged commit 08808db into realsenseai:development May 29, 2024
@maloel
maloel deleted the logging-fixes branch May 29, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants