Skip to content

Enable dds flow controller - #12983

Merged
maloel merged 4 commits into
realsenseai:developmentfrom
maloel:flow-controller
May 30, 2024
Merged

Enable dds flow controller#12983
maloel merged 4 commits into
realsenseai:developmentfrom
maloel:flow-controller

Conversation

@maloel

@maloel maloel commented May 30, 2024

Copy link
Copy Markdown
Contributor

Following #12924, this actually enables:

  • 1470 max write packet size
  • 256*1470 every 100ms "dfu" flow controller now defined and used in DFU
  • updated scripts/topic-send.py to use a similar flow and adjust the ACK timeout based on the file size

Also:

  • remove topic-sink --time default (was 5), so it waits forever
  • do not show the default FastDDS flow controller "FastDDSFlowControllerDefault" in operator<<

@maloel
maloel requested a review from OhadMeir May 30, 2024 05:28
OhadMeir
OhadMeir approved these changes May 30, 2024
View reviewed changes

@OhadMeir OhadMeir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maloel
maloel merged commit 73c623c into realsenseai:development May 30, 2024
@maloel
maloel deleted the flow-controller branch May 30, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OhadMeir OhadMeir OhadMeir approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maloel @OhadMeir