Update libcurl version to latest version 8.8.0 - #13007
Merged
Merged
Conversation
Nir-Az
marked this pull request as ready for review
June 9, 2024 08:06
remibettan
reviewed
Jun 9, 2024
| # Add SSL library flag | ||
| if (WIN32) | ||
| set(CURL_FLAGS ${CURL_FLAGS} -DCMAKE_USE_SCHANNEL=ON ) | ||
| set(CURL_FLAGS ${CURL_FLAGS} -DCURL_USE_SCHANNEL=ON ) |
Contributor
There was a problem hiding this comment.
can you explain this change please?
Collaborator
Author
There was a problem hiding this comment.
API change on LibCURL Cmake files, parameter name was changed
cmake: private identifiers use CURL_ instead of CMAKE_ prefix](curl/curl#7988)
remibettan
reviewed
Jun 9, 2024
| message(STATUS "Building libcurl enabled") | ||
|
|
||
| set(CURL_FLAGS -DBUILD_CURL_EXE=OFF -DBUILD_SHARED_LIBS=OFF -DUSE_WIN32_LDAP=OFF -DHTTP_ONLY=ON -DCURL_ZLIB=OFF -DCURL_DISABLE_CRYPTO_AUTH=ON -DCMAKE_USE_LIBSSH2=OFF -DBUILD_TESTING=OFF ) | ||
| set(CURL_FLAGS -DBUILD_CURL_EXE=OFF -DBUILD_SHARED_LIBS=OFF -DUSE_WIN32_LDAP=OFF -DHTTP_ONLY=ON -DCURL_ZLIB=OFF -DCURL_DISABLE_CRYPTO_AUTH=ON -DCURL_USE_LIBSSH2=OFF -DCURL_DISABLE_TESTS=ON ) |
Contributor
There was a problem hiding this comment.
can you explain this change please?
remibettan
self-requested a review
June 9, 2024 09:47
|
Hi, Im unable to build from source because of a missing libcurl documentation. Please see #13709 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified on Win + Linux
Tracked on [LRS-1112]