add motion_frame::get_combined_motion_data() for DDS Motion streams - #13042
Merged
Conversation
OhadMeir
approved these changes
Jun 17, 2024
Contributor
Author
|
I pushed a change to the comments in rs_frame.hpp, to make it clearer when to use either function. |
Contributor
Author
|
Just for reference, an example of usage: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No API existed to get the combined motion data.
The previous API in
rs2::motion_frameisget_motion_data()returningrs2_vectorwhich ASSUMES the data type. This should be used withRS2_FORMAT_MOTION_XYZ32F.I did the same: added
get_combined_motion_data()returningrs2_combined_motion. This should be used withRS2_FORMAT_COMBINED_MOTION.I.e., it is up to the user to call the right one.
Added Python API.
Tracked on [RSDEV-2243]