change get/set calibration config API to work with JSONs directly - #13168
Merged
SamerKhshiboun merged 2 commits intoJul 21, 2024
Merged
Conversation
SamerKhshiboun
force-pushed
the
change_calib_config_api
branch
9 times, most recently
from
July 18, 2024 17:48
7a58dab to
4bd86d2
Compare
SamerKhshiboun
force-pushed
the
change_calib_config_api
branch
from
July 18, 2024 23:23
4bd86d2 to
ef06acb
Compare
SamerKhshiboun
marked this pull request as ready for review
July 19, 2024 09:14
Nir-Az
reviewed
Jul 21, 2024
| static_cast<int>(ds::d500_calib_type::d500_calib_dynamic)); | ||
| cmd.require_response = true; | ||
|
|
||
| // send command to device and get response (safety_interface_config entry + header) |
Nir-Az
reviewed
Jul 21, 2024
Nir-Az
reviewed
Jul 21, 2024
| # License: Apache 2.0. See LICENSE file in root directory. | ||
| # Copyright(c) 2024 Intel Corporation. All Rights Reserved. | ||
|
|
||
| # test:donotrun |
Collaborator
There was a problem hiding this comment.
Maybe we should only add it to the relevant branch?
Or place a comment to "uncomment" this when D555e is connected to LibCI?
Contributor
Author
There was a problem hiding this comment.
Fixed. Added a comment.
Nir-Az
reviewed
Jul 21, 2024
| test.start("Writing calibration config, then reading and comparing calibration config JSONs") | ||
|
|
||
| # save current calibration config json in order to restore it at the end | ||
| original_calib_config = ac_dev.get_calibration_config() |
Collaborator
There was a problem hiding this comment.
Not sure we want to write calibration tables..
If the test stop in the middle we will get a very bad calibration table on the CI machines no?
How do you think we can make this more robust?
Contributor
Author
There was a problem hiding this comment.
Let's decide this offline.
Nir-Az
approved these changes
Jul 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tested in
https://github.com/IntelRealSense/librealsense-private/pull/307
new unit test passed and sanity checks passed