Skip to content

fix #13185 & #13192: move inline bool operator to json.h - #13202

Merged
maloel merged 2 commits into
realsenseai:developmentfrom
maloel:json-warnings
Jul 29, 2024
Merged

fix #13185 & #13192: move inline bool operator to json.h#13202
maloel merged 2 commits into
realsenseai:developmentfrom
maloel:json-warnings

Conversation

@maloel

@maloel maloel commented Jul 29, 2024

Copy link
Copy Markdown
Contributor

PR #13192 caused warnings under Linux:

In file included from /home/jenkins/workspace/LRS_linux_compile_lib_ci/src/core/option-interface.h:8,
                 from /home/jenkins/workspace/LRS_linux_compile_lib_ci/src/option.h:5,
                 from /home/jenkins/workspace/LRS_linux_compile_lib_ci/src/source.cpp:6:
/home/jenkins/workspace/LRS_linux_compile_lib_ci/third-party/rsutils/include/rsutils/json-fwd.h:41:17: warning: inline function 'bool rsutils::json_base::exists() const' used but never defined
   41 |     inline bool exists() const;
      |                 ^~~~~~

Moved inline operator bool() to json.h.

Fixed additional Python SyntaxWarning: invalid escape sequence '\ ' warnings for backslash usage with invalid following character.

@maloel
maloel requested a review from OhadMeir July 29, 2024 05:41
@maloel
maloel merged commit b0d4926 into realsenseai:development Jul 29, 2024
@maloel
maloel deleted the json-warnings branch July 29, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants