Skip to content

linux v4l2 backend - method get_devname_from_video_path efficiency improved - #13296

Merged
remibettan merged 2 commits into
realsenseai:developmentfrom
remibettan:dev_without_video_paths_in_linux_be
Aug 27, 2024
Merged

linux v4l2 backend - method get_devname_from_video_path efficiency improved#13296
remibettan merged 2 commits into
realsenseai:developmentfrom
remibettan:dev_without_video_paths_in_linux_be

Conversation

@remibettan

Copy link
Copy Markdown
Contributor

Tracked by: RSDSO-19712

@remibettan
remibettan requested a review from dmipx August 27, 2024 12:00
Comment thread src/linux/backend-v4l2.cpp Outdated
if (!uevent_file)
std::string devname;
bool for_dfu = true;
if (get_devname_from_video_path(real_path, devname, for_dfu))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is not necessarily needed - after all - we append /dev/:
auto mipi_dfu_chardev = "/dev/" + dfu_device_path;

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great - thanks

@dmipx dmipx left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@remibettan
remibettan requested a review from OhadMeir August 27, 2024 13:54
@remibettan
remibettan merged commit 07ac94e into realsenseai:development Aug 27, 2024
@Nir-Az Nir-Az changed the title modify the method get_devname_from_video_path linux v4l2 backend - method get_devname_from_video_path efficiency improved Aug 29, 2024
@remibettan
remibettan deleted the dev_without_video_paths_in_linux_be branch July 29, 2025 14:07
@ciandonovan

Copy link
Copy Markdown
Contributor

URGENT—broke production librealsense in unprivileged containers

This PR undid the work of #11900 to make librealsense usable in unprivileged containers, and since being backported to Jazzy has broken our prod.

What was this PR in aid of? What efficiency improvements did it provide? Can it be reverted ASAP?

@Nir-Az

Nir-Az commented Aug 24, 2025

Copy link
Copy Markdown
Collaborator

URGENT—broke production librealsense in unprivileged containers

This PR undid the work of #11900 to make librealsense usable in unprivileged containers, and since being backported to Jazzy has broken our prod.

What was this PR in aid of? What efficiency improvements did it provide? Can it be reverted ASAP?

@ciandonovan Sorry for the inconvenience, and for the hard work that was done by you and got changed later on.
We will try to assist as best as we can, the changes were done when we fixed an issue of slow enumeration when multiple cameras are connected that occurs after that change.
We sent an offline mail to get more details so we can reproduce and find a way that will, hopefully this time we can also add a regression test that will keep your use case valid on next releases.

For now I can suggest you to pin point 2.55.1 / 4.55.1 versions on your build in order to keep your system stable and allow us time to investigate and solve the issue properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants