Skip to content

Remove live-test build - #13321

Merged
Nir-Az merged 4 commits into
realsenseai:developmentfrom
noacoohen:remove_legacy_live_tests_fix
Sep 8, 2024
Merged

Remove live-test build#13321
Nir-Az merged 4 commits into
realsenseai:developmentfrom
noacoohen:remove_legacy_live_tests_fix

Conversation

@noacoohen

Copy link
Copy Markdown
Contributor

Remove remaining code related to legacy-live-tests

Tracked by LRS-1173

@noacoohen
noacoohen requested a review from Nir-Az September 5, 2024 08:55
@Nir-Az
Nir-Az requested review from Arun-Prasad-V and removed request for Nir-Az September 5, 2024 08:58
Comment thread .github/workflows/buildsCI.yaml Outdated
export LRS_LOG_LEVEL="DEBUG";
cd build/${{env.LRS_RUN_CONFIG}}/
./live-test -d yes -i [software-device]
cd build/${{env.LRS_RUN_CONFIG}}/

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noacoohen, do we need U20_U24_ST_Py_EX_CfU_LiveTest section, if no live tests are ran?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW the name is wrong right? Its U22 U24?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Arun-Prasad-V ,This is the only build that compiles Ubuntu with Examples & Tools or with Check for Updates so I didn't remove it

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nir-Az, yes, I'll change it

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noacoohen, okay got it. Then, does it make sense to remove _LiveTest from the name and also remove the Test section if we are not going to test anything?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment thread .github/workflows/buildsCI.yaml Outdated
export LRS_LOG_LEVEL="DEBUG";
cd build/${{env.LRS_RUN_CONFIG}}/

- name: Upload RS log artifact

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO since the test step dropped, we will have no log artifact and this stage can be deleted as well, right?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, removed

Comment thread .github/workflows/buildsCI.yaml
Comment thread .github/workflows/buildsCI.yaml Outdated
name: Log file - ${{ matrix.name }}_ST_Py_EX_CfU_LiveTest
path: build/${{env.LRS_RUN_CONFIG}}/*.log

- name: Provide correct exit status for job

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but I just noticed the last stage which is also not needed :)
No more tests

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@Nir-Az
Nir-Az merged commit b56ef5e into realsenseai:development Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants