Skip to content

Table read error fallback - #13512

Merged
Nir-Az merged 3 commits into
realsenseai:developmentfrom
Nir-Az:empty-flash
Nov 14, 2024
Merged

Table read error fallback#13512
Nir-Az merged 3 commits into
realsenseai:developmentfrom
Nir-Az:empty-flash

Conversation

@Nir-Az

@Nir-Az Nir-Az commented Nov 13, 2024

Copy link
Copy Markdown
Collaborator

We wish to allow the camera to enumerate even no flash tables.
image

Tracked on [RSDEV-2874] [RSDEV-2901]

Comment thread src/ds/d500/d500-device.cpp Outdated
Comment thread src/ds/d500/d500-private.cpp Outdated

@remibettan remibettan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sematic comments - great improvement!

@Nir-Az

Nir-Az commented Nov 14, 2024

Copy link
Copy Markdown
Collaborator Author

Notes from @ev-mp

  1. Can you add a note whether this applies to RGB or Depth sensor intrinsic for clarity?
  2. What is the impact of returning empty intrinsic ? Providing arbitrary values may mask the issue making the user unaware of the actual problem

@Nir-Az

Nir-Az commented Nov 14, 2024

Copy link
Copy Markdown
Collaborator Author

Notes from @ev-mp

  1. Can you add a note whether this applies to RGB or Depth sensor intrinsic for clarity?
  2. What is the impact of returning empty intrinsic ? Providing arbitrary values may mask the issue making the user unaware of the actual problem
  1. Yes will do
  2. The user will get a log error, if you prefer I can have an internal flag and override the start stream function and throw on this case, not sure it is worth it. thoughts?

@ev-mp ev-mp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nir-Az
Nir-Az merged commit 2fea862 into realsenseai:development Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants