Don't nullify on_frame_ready lambda - #13650
Merged
Merged
Conversation
maloel
approved these changes
Jan 2, 2025
maloel
left a comment
Contributor
There was a problem hiding this comment.
Looks good. I assume this is tested and better?
Contributor
|
Also, please describe the problem and suspected root-cause in the description. |
Contributor
Author
OK. It is described in the Jira ticket by I will also add a short description here. |
Nir-Az
approved these changes
Jan 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked on [RSDEV-3022]
We have experienced segmentation faults on Linux while running a start-stop loop test.
Root cause of the problem is handling frame callback in one thread, while stopping in another. Stop deleted the lambda expression calling the user callback, returning from the callback have issued the fault.