minimize frame skip so FPS will be calculated ASAP - #13658
Merged
Nir-Az merged 4 commits intoJan 12, 2025
Merged
Conversation
also handled some non-proper comparison with floating point number. until FPS calculation is ready, display '--' on screen (instead of zero)
Nir-Az
reviewed
Jan 7, 2025
Nir-Az
reviewed
Jan 7, 2025
Nir-Az
reviewed
Jan 7, 2025
the root cause is the unsigned long underflow when we playback a bag file. when we finish the file and go back to the first frame, the current frame - last frame turnes out top be negative (underflow) which cases the invalid value display on the UI Revert "minimize frame skip so FPS will be calculated ASAP." This reverts commit 8a5c42c.
Nir-Az
approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root cause is the unsigned long underflow when we playback a bag file.
when we finish the file and go back to the first frame, the current frame - last frame turns out to be negative (underflow) which cases the invalid value display on the UI
Tracked on [RSDSO-19945]