add more info to logs in fps_helper - #13669
Merged
Merged
Conversation
Nir-Az
reviewed
Jan 9, 2025
| profile_name_fps_dict[profile_name] += 1 | ||
| log.d(f"frame {frame.profile.stream_name()} #{profile_name_fps_dict[frame.profile.stream_name()] + 1} finished") | ||
| log.d(f"frame {frame.profile.stream_name()} #{profile_name_fps_dict[frame.profile.stream_name()]} " | ||
| f"callback finished") |
Collaborator
There was a problem hiding this comment.
Can you explain this change? +1 dropped
Contributor
Author
There was a problem hiding this comment.
The idea was to show the correct frame number, since we've just increased it inside the 'if', but I noticed it's still wrong when we don't count frames.
I just fixed it now, so the two logs make sense now, whether or not we count frames.
Nir-Az
approved these changes
Jan 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.