Skip to content

Add Y16 support to D555 - #13700

Merged
OhadMeir merged 2 commits into
realsenseai:developmentfrom
OhadMeir:y16
Jan 23, 2025
Merged

Add Y16 support to D555#13700
OhadMeir merged 2 commits into
realsenseai:developmentfrom
OhadMeir:y16

Conversation

@OhadMeir

Copy link
Copy Markdown
Contributor

Tracked on [RSDEV-2612]

Format is "mono16" to be ROS compatible. Added processing block to handle 10bit data scale to 16bit.
Renamed y16i-to-y10msby10msb to y16i-10msb-to-y16y16.

@OhadMeir
OhadMeir requested a review from remibettan January 23, 2025 06:42
Comment thread src/proc/y16_10msb-to-y16.cpp Outdated
// License: Apache 2.0. See LICENSE file in root directory.
// Copyright(c) 2022 Intel Corporation. All Rights Reserved.

#include "y16_10msb-to-y16.h"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the file's name is weird: you have half "_" and half "-".
Besides that, you chose to rename to y16i_10msb_to_y16y16 - so one "y16 is missing in the file's name.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the _ in the file name.
There are two files, existing that converts interleaved y16i to two y16 streams and was renamed. Plus a new file that handles one y16 stream with 10 bit data and scales it to 16 bit data.

@remibettan remibettan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments

@remibettan remibettan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OhadMeir
OhadMeir merged commit c0b18f2 into realsenseai:development Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants