Skip to content

Replace setup.py with pyproject.toml - #13722

Merged
Nir-Az merged 7 commits into
realsenseai:developmentfrom
Noy-Zini:replace-setup.py-with-pyproject.toml
Mar 6, 2025
Merged

Replace setup.py with pyproject.toml#13722
Nir-Az merged 7 commits into
realsenseai:developmentfrom
Noy-Zini:replace-setup.py-with-pyproject.toml

Conversation

@Noy-Zini

Copy link
Copy Markdown
Contributor

Tracked on : [LRS-1214]

@Noy-Zini
Noy-Zini force-pushed the replace-setup.py-with-pyproject.toml branch 4 times, most recently from 320e414 to 7d51c23 Compare January 29, 2025 18:24
@Noy-Zini
Noy-Zini force-pushed the replace-setup.py-with-pyproject.toml branch 8 times, most recently from 227aa07 to fc04848 Compare February 25, 2025 15:09
@Noy-Zini
Noy-Zini force-pushed the replace-setup.py-with-pyproject.toml branch from fc04848 to 239769d Compare March 2, 2025 10:05
@Noy-Zini
Noy-Zini force-pushed the replace-setup.py-with-pyproject.toml branch 6 times, most recently from 1446fe4 to 421c763 Compare March 3, 2025 09:43
@Noy-Zini
Noy-Zini force-pushed the replace-setup.py-with-pyproject.toml branch from 421c763 to 61e1c6e Compare March 4, 2025 09:57
@Noy-Zini
Noy-Zini force-pushed the replace-setup.py-with-pyproject.toml branch from d98cd48 to 9e52363 Compare March 6, 2025 09:15
@Noy-Zini
Noy-Zini requested a review from Nir-Az March 6, 2025 09:42
Comment thread wrappers/python/pyproject.toml Outdated
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tab --> spaces

@Nir-Az

Nir-Az commented Mar 6, 2025

Copy link
Copy Markdown
Collaborator

This should come with a CI PR too right?
Please elaborate on how it was tested

@Nir-Az Nir-Az left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nir-Az
Nir-Az merged commit 1c9d0c0 into realsenseai:development Mar 6, 2025
@Noy-Zini

Noy-Zini commented Mar 6, 2025

Copy link
Copy Markdown
Contributor Author

I tested each Python wheel generated by the build for the corresponding Python version and platform.
For each test, I installed the wheel using pip install, then verified it by importing pyrealsense2 and using it to open a context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants