Fix LibCI failure counter - #13851
Merged
Merged
Conversation
Nir-Az
reviewed
Mar 13, 2025
| if test_wrapper_( test, configuration, repetition, retry, test.config.retries, serial_numbers ): | ||
| return True | ||
|
|
||
| log._n_errors += 1 |
Collaborator
There was a problem hiding this comment.
Will it still count errors w/o this change?
Contributor
Author
There was a problem hiding this comment.
Yes, errors are counted by the failed test calling log.e.
In this function there was a loop for the retries that "knew" that each retry will increase the log, so it decreased it back, and this line was supposed to add one to the counter for all retries. Previous PR removed the decrease (and made the log.e call only on last retry), but I did not remove this increase.
Nir-Az
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following PR#13817
LibCI counts failed tests number erroneously. Error counter should be handled via
logmodule calls only.