Skip to content

Remove Xenial patches and scripts - #13876

Merged
Nir-Az merged 2 commits into
realsenseai:developmentfrom
AviaAv:scripts-cleanup
Apr 2, 2025
Merged

Remove Xenial patches and scripts#13876
Nir-Az merged 2 commits into
realsenseai:developmentfrom
AviaAv:scripts-cleanup

Conversation

@AviaAv

@AviaAv AviaAv commented Mar 23, 2025

Copy link
Copy Markdown
Contributor

Tracked on: [LRS-1145]

@AviaAv
AviaAv requested a review from Nir-Az March 23, 2025 11:25
#[ $k_maj_min -ge 605 ] && skip_md_patch=1

# Construct branch name from distribution codename {xenial,bionic,..} and kernel version
# Construct branch name from distribution codename {bionic,focal...} and kernel version

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bionic can also be removed.
We support min focal.
Same for all places

@@ -43,14 +43,6 @@ PLATFORM=$(uname -n)
#fi
kernel_branch="master"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file at all

@@ -39,12 +39,12 @@ else
kernel_branch=$(choose_kernel_branch $LINUX_BRANCH)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this file

@AviaAv AviaAv Mar 26, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We refer to it in our doc, installation_odroid.md, remove that file too?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Comment thread scripts/patch-ubuntu-kernel-4.16.sh Outdated
LINUX_BRANCH=$(uname -r)

# Construct branch name from distribution codename {xenial,bionic,..} and kernel version
# Construct branch name from distribution codename {bionic, focal...} and kernel version

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure bionic has kernel 4.16.
I think we can drop this file.
Just make sure that on the installation doc no more references to files we delete

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't mention this file in our doc, the only references we have to files we remove are in installation_odroid.md and DSO-1369.md, both seem fairly old

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also delete both

#[ $k_maj_min -ge 605 ] && skip_md_patch=1

# Construct branch name from distribution codename {bionic,focal...} and kernel version
# Construct branch name from distribution codename {focal, jammy...} and kernel version

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try running this script so we can make sure it works before we merge.
This is our main patches script

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followed the documentation with the modified script on a VM, the camera was detected fine

@Nir-Az
Nir-Az merged commit 1affcb8 into realsenseai:development Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants