remove age and gender from RealSense Viewer - #14012
Merged
Nir-Az merged 3 commits intoMay 20, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes all age and gender detection components from the RealSense Viewer, including associated classes, methods, and UI labels.
- Deleted the age-gender detection header and implementation files
- Updated the face-detection pipeline and
detected_faceclass to no longer track or display age/gender - Cleaned up related documentation and comments
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| wrappers/openvino/rs-vino/openvino-helpers.h | Adjusted face bbox helper comment |
| wrappers/openvino/rs-vino/base-detection.h | Removed age_gender_detection reference from base class comment |
| wrappers/openvino/rs-vino/age-gender-detection.h | Deleted age-gender detection header |
| wrappers/openvino/rs-vino/age-gender-detection.cpp | Deleted age-gender detection implementation |
| tools/realsense-viewer/openvino-face-detection.cpp | Removed age/gender logic and updated detected_face class |
Files not reviewed (1)
- tools/realsense-viewer/CMakeLists.txt: Language not supported
Comments suppressed due to low confidence (2)
tools/realsense-viewer/openvino-face-detection.cpp:30
- This stray brace appears to be left over from the removed
update_gendermethod; it should be removed to avoid a dangling block.
{
tools/realsense-viewer/openvino-face-detection.cpp:31
- Remove this closing brace which currently forms an empty block unassociated with any method.
}
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes age and gender detection functionality from the RealSense Viewer, including related model loading, inference, and UI labels.
- Eliminated
age_gender_detectionclass and its includes. - Stripped age/gender logic and parameters from
detected_faceandopenvino_face_detection. - Cleaned up associated comments and UI string construction.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| wrappers/openvino/rs-vino/openvino-helpers.h | Removed gender-related example from bbox comment. |
| wrappers/openvino/rs-vino/base-detection.h | Deleted age/gender mention in class comment. |
| wrappers/openvino/rs-vino/age-gender-detection.h | Removed entire file for age/gender detection. |
| wrappers/openvino/rs-vino/age-gender-detection.cpp | Removed entire implementation file. |
| tools/realsense-viewer/openvino-face-detection.cpp | Stripped out age/gender logic, constructor params, model loads, and UI labels. |
Files not reviewed (1)
- tools/realsense-viewer/CMakeLists.txt: Language not supported
Comments suppressed due to low confidence (1)
tools/realsense-viewer/openvino-face-detection.cpp:330
- [nitpick] Using
rsutils::string::from()without any appended data may be unclear and incurs unnecessary formatting overhead; consider passing an explicit empty string literal""or using an overload that omits the label argument.
objects.emplace_back(
face->get_id(),
rsutils::string::from(),
normalized_color_bbox,
normalized_depth_bbox,
face->get_depth()
);
Nir-Az
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked on [LRS-1261]