Enable tests for D555 - #14056
Merged
Merged
Conversation
Nir-Az
reviewed
Jun 10, 2025
| max_delay_for_color_frame = 1 | ||
| elif product_line == "D500": | ||
| max_delay_for_depth_frame = 1 | ||
| max_delay_for_color_frame = 1 |
Collaborator
There was a problem hiding this comment.
Pipeline start take less than 1 sec for D555?
Nir-Az
reviewed
Jun 10, 2025
| device_removed = False | ||
| device_added = False | ||
| MAX_ENUM_TIME_D400 = 5 # [sec] | ||
| MAX_ENUM_TIME_D500 = 18 # [sec] |
Contributor
There was a problem hiding this comment.
We have seen in Wireshark that D555 sometimes goes back up after 13 seconds. Giving a few additional seconds for discovery and initialization 18 seems OK.
You might want to limit it based on connection type? USB should be faster. Don't know how long it would take for future D500 products...
Collaborator
There was a problem hiding this comment.
Let's do the timing based on connection type like Ohad suggested please
Nir-Az
reviewed
Jun 10, 2025
|
|
||
|
|
||
| #test:device each(D400*) !D457 | ||
| #test:device each(D500*) !D555 |
Collaborator
There was a problem hiding this comment.
Will this pass without finding a D500 device?
Contributor
Author
There was a problem hiding this comment.
Yes - tested with just a D400 connected and it passed
OhadMeir
reviewed
Jun 10, 2025
| @@ -31,6 +33,8 @@ def device_changed( info ): | |||
| def get_max_enum_rime_by_device( dev ): | |||
Collaborator
Nir-Az
approved these changes
Jun 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Tracked on: [LRS-1253]