Skip to content

Enable tests for D555 - #14056

Merged
Nir-Az merged 4 commits into
realsenseai:developmentfrom
AviaAv:dds-tests
Jun 15, 2025
Merged

Enable tests for D555#14056
Nir-Az merged 4 commits into
realsenseai:developmentfrom
AviaAv:dds-tests

Conversation

@AviaAv

@AviaAv AviaAv commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

Tracked on: [LRS-1253]

@AviaAv
AviaAv requested a review from Nir-Az June 10, 2025 09:08
max_delay_for_color_frame = 1
elif product_line == "D500":
max_delay_for_depth_frame = 1
max_delay_for_color_frame = 1

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pipeline start take less than 1 sec for D555?

Comment thread unit-tests/live/hw-reset/test-t2enum.py Outdated
device_removed = False
device_added = False
MAX_ENUM_TIME_D400 = 5 # [sec]
MAX_ENUM_TIME_D500 = 18 # [sec]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OhadMeir 18 sec is acceptable?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have seen in Wireshark that D555 sometimes goes back up after 13 seconds. Giving a few additional seconds for discovery and initialization 18 seems OK.

You might want to limit it based on connection type? USB should be faster. Don't know how long it would take for future D500 products...

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do the timing based on connection type like Ohad suggested please



#test:device each(D400*) !D457
#test:device each(D500*) !D555

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this pass without finding a D500 device?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - tested with just a D400 connected and it passed

Comment thread unit-tests/live/hw-reset/test-t2enum.py Outdated
@@ -31,6 +33,8 @@ def device_changed( info ):
def get_max_enum_rime_by_device( dev ):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo "rime"

@Nir-Az

Nir-Az commented Jun 10, 2025

Copy link
Copy Markdown
Collaborator

image
Do we need to enable DDS in order to make this work?
Can you also attach a CI run that passed?

@Nir-Az
Nir-Az merged commit 7ed3bc5 into realsenseai:development Jun 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants