Skip to content

fix UI multi camera advanced mode - #14057

Merged
Nir-Az merged 2 commits into
realsenseai:developmentfrom
Noy-Zini:fix-UI-multi-camera-advanced-mode
Jun 15, 2025
Merged

fix UI multi camera advanced mode#14057
Nir-Az merged 2 commits into
realsenseai:developmentfrom
Noy-Zini:fix-UI-multi-camera-advanced-mode

Conversation

@Noy-Zini

Copy link
Copy Markdown
Contributor

Tracked on [RSDSO-20278]

@Noy-Zini
Noy-Zini requested a review from Nir-Az June 10, 2025 14:22
@Nir-Az
Nir-Az requested review from remibettan and removed request for Nir-Az June 11, 2025 12:31
Comment thread common/device-model.h Outdated
std::set<std::string> advanced_mode_settings_file_names;
std::string selected_file_preset;

bool show_advanced_mode_popup = false;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this param can be private instead of public. If so, please make it private.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved it to private.

@Noy-Zini
Noy-Zini force-pushed the fix-UI-multi-camera-advanced-mode branch from 524e2b5 to 7e37d22 Compare June 15, 2025 06:14
@Noy-Zini
Noy-Zini force-pushed the fix-UI-multi-camera-advanced-mode branch from 7e37d22 to 939f78b Compare June 15, 2025 06:48
@Noy-Zini
Noy-Zini requested review from Nir-Az and remibettan June 15, 2025 06:49
@Nir-Az
Nir-Az merged commit 172e5ad into realsenseai:development Jun 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants