IQ basic depth test - #14097
Merged
Nir-Az merged 4 commits intoAug 13, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new unit test for verifying the basic depth accuracy using Intel RealSense hardware.
- Introduces a new test script to validate depth values against known expected measurements
- Implements logging of frame-level mismatches and uses a pass-rate threshold for validation
Comment on lines
+63
to
+65
| test.finish() | ||
| pipeline.stop() |
There was a problem hiding this comment.
Consider moving pipeline.stop() into a finally block to ensure resources are properly released even if an exception occurs. This guarantees that the pipeline is stopped regardless of test outcomes.
Suggested change
| test.finish() | |
| pipeline.stop() | |
| finally: | |
| if 'pipeline' in locals(): | |
| pipeline.stop() | |
| test.finish() |
Collaborator
|
Please add a "donotrun" label so we can merge it |
Noy-Zini
force-pushed
the
Basic-depth-image-quality-test
branch
from
August 13, 2025 11:10
679983c to
aa7a308
Compare
Nir-Az
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracked on: [LRS-1288]