Create test-texture-mapping.py - #14099
Merged
Nir-Az merged 3 commits intoAug 13, 2025
Merged
Conversation
Noy-Zini
force-pushed
the
texture-mapping-image-quality-test
branch
from
June 24, 2025 15:21
bacfb92 to
7df621b
Compare
Nir-Az
reviewed
Jun 24, 2025
| for name, ((x, y), expected_rgb) in expected_mappings.items(): | ||
| depth = depth_frame.get_distance(x, y) | ||
| if depth == 0: | ||
| log.w(f"Frame {frame_index} - {name}: No depth at ({x},{y})") |
Collaborator
There was a problem hiding this comment.
We can skip that IMO,
We do not have 100% fill rate on most scenes
Nir-Az
reviewed
Jun 24, 2025
|
|
||
| # Texture mapping: | ||
| # Deproject (x, y) + depth to 3D point in depth camera space | ||
| depth_point = rs.rs2_deproject_pixel_to_point(depth_intr, [x, y], depth) |
Collaborator
There was a problem hiding this comment.
I think you implemented what is already implemented inside the SDK.
We already have an alignment and texture mapping API
See here: https://github.com/IntelRealSense/librealsense/blob/development/examples/align/rs-align.cpp
Collaborator
|
Please add a "donotrun" label so we can merge it |
Nir-Az
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracked on : LRS-1289