Enable playback tests for D555 - #14140
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Enables playback tests for D555 devices across rec-play unit tests and enhances core ROS reader and DDS proxy logic to support stereo depth sensors.
- Added D500 series device metadata to several rec-play test scripts and tweaked stress test parameters.
- Extended ros_reader to recognize stereo depth sensors, cache stream extrinsics, and compute baseline from extrinsics.
- Updated DDS depth sensor proxy to implement
extend_tofor both depth and stereo depth sensor interfaces.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| unit-tests/live/rec-play/test-record-and-stream.py | Added D500 device test metadata |
| unit-tests/live/rec-play/test-playback-stress.py | Reduced timeout and iteration count for playback stress test |
| unit-tests/live/rec-play/test-pause-playback-frames.py | Added D500 device test metadata |
| unit-tests/live/rec-play/test-non-realtime.py | Added note about D555 incompatibility (typo present) |
| unit-tests/live/rec-play/test-got-playback-frames.py | Added D500 device test metadata |
| src/media/ros/ros_reader.h | Declared new is_stereo_depth_sensor method and extrinsics map |
| src/media/ros/ros_reader.cpp | Implemented stereo depth logic, extrinsics caching, and baseline |
| src/dds/rs-dds-depth-sensor-proxy.h | Declared extend_to override |
| src/dds/rs-dds-depth-sensor-proxy.cpp | Implemented extend_to to support depth and stereo depth sensors |
Comments suppressed due to low confidence (1)
unit-tests/live/rec-play/test-playback-stress.py:16
- [nitpick] The iteration count was reduced from 250 to 20, which may significantly decrease stress test coverage; consider documenting or adjusting this to ensure adequate testing.
number_of_iterations = 20
remibettan
reviewed
Jul 20, 2025
| bool ros_reader::is_depth_sensor(std::string sensor_name) | ||
| { | ||
| if (sensor_name.compare("Stereo Module") == 0 || sensor_name.compare("Coded-Light Depth Sensor") == 0) | ||
| if( is_stereo_depth_sensor( sensor_name ) || sensor_name.compare( "Coded-Light Depth Sensor" ) == 0 ) |
Contributor
There was a problem hiding this comment.
can be rplacced by:
return ( is_stereo_depth_sensor( sensor_name ) || sensor_name.compare( "Coded-Light Depth Sensor" ) == 0 );
Instead of the return true, return false.
Can also be inlined in the h file (as the implementation is so short.
remibettan
reviewed
Jul 20, 2025
remibettan
left a comment
Contributor
There was a problem hiding this comment.
One comment - besides that LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked on [LRS-1283]