Add Auto HDR support - #14159
Merged
Merged
Conversation
Nir-Az
reviewed
Jul 23, 2025
Nir-Az
reviewed
Jul 23, 2025
|
|
||
| initialize_default_config(); | ||
| load_hdr_config_from_device(); | ||
| //load_hdr_config_from_device(); |
Nir-Az
reviewed
Jul 23, 2025
| // pairs of gain and exposure | ||
| const std::vector< std::pair< int, int > > defaults = { { 16, (int)_exp_range.min }, { 16, 32000 } }; | ||
| for (auto const& p : defaults) | ||
| const std::vector< std::pair< int, int > > man_defaults = { { 16, (int)_exp_range.min }, { 16, 32000 } }; |
Collaborator
There was a problem hiding this comment.
Why do we only have ex_min as a variable and all other are hard coded?
Collaborator
|
Looks good overall, please update once it is ready for merge |
OhadMeir
reviewed
Jul 27, 2025
| const auto& controls = item.at("controls"); | ||
| for (const auto& control : controls) { | ||
| for (const auto& kv : controls.items()) { | ||
| // just begin() because the control is a single object |
OhadMeir
reviewed
Jul 27, 2025
| int depth_man_exp; | ||
| int depth_exp; | ||
|
|
||
| int delta_gain; |
Contributor
There was a problem hiding this comment.
It seems that you only use depth_gain/exp or delta_gain/exp. Why do we need this duplicity? Can use a single pair of values and set to needed fields
Contributor
Author
There was a problem hiding this comment.
The idea is to keep the values of both modes, even if we switch between them - for example, if we were on Auto mode and we switch to Manual mode, we will display the old Manual mode values instead of the Auto mode ones
OhadMeir
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked on: [RSDSO-19396]