fix dds targets issue on debian - #14203
Merged
Merged
Conversation
Nir-Az
reviewed
Aug 11, 2025
| include(CMakeFindDependencyMacro) | ||
|
|
||
| # Ask CMake to find the packages that provide the targets referenced by realsense2Targets.cmake | ||
| find_dependency(fastcdr CONFIG REQUIRED) |
Collaborator
There was a problem hiding this comment.
We only want this when DDS is on right?
No dependency if it's not, possible?
Nir-Az
reviewed
Aug 12, 2025
| install(TARGETS dds fastrtps eProsima_atomic EXPORT realsense2Targets) | ||
|
|
||
| # install in order to set ARCHIVE DESTINATION - to put libfastcdr.a into the x86_64 folder | ||
| install(TARGETS fastcdr |
Collaborator
There was a problem hiding this comment.
Add a comment about why it is needed at all
Nir-Az
reviewed
Aug 12, 2025
| add_definitions(-DBUILD_WITH_DDS) | ||
|
|
||
| install(TARGETS dds EXPORT realsense2Targets) | ||
| install(TARGETS dds fastrtps eProsima_atomic EXPORT realsense2Targets) |
Contributor
Author
There was a problem hiding this comment.
Needed by realdds
CMake Error: install(EXPORT "realsense2Targets" ...) includes target "realdds" which requires target "dds" that is not in any export set.
Nir-Az
reviewed
Aug 12, 2025
| @@ -1,4 +1,7 @@ | |||
| @PACKAGE_INIT@ | |||
| include(CMakeFindDependencyMacro) | |||
Collaborator
There was a problem hiding this comment.
Check if needed or can be moved
Contributor
Author
There was a problem hiding this comment.
Needed because REALSENSE2_DDS_DEPENDENCIES contains find_dependency, but moved to the other file
Nir-Az
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked on: [RSDSO-20432]